Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional keyring dependency target in pyproject.toml #2109

Merged
merged 3 commits into from Jul 19, 2023

Conversation

deronnax
Copy link
Sponsor Contributor

Hello.
Thank you very much for PDM, incredible work, much appreciated here.

We are considering recommending PDM for the whole company, but we would very much need our contributors being able to install PDM "the right way" (meaning: with keyring included from the start) in one go, simply (and not having to run pip install keyring or pipx inject pdm keyring afterward), because we really value the password being stored in a safe way. And what comes with the all optional dependencies really looks irrelevant and cumbersome for our use case.
We think keyring is a very, very import dependency. For comparison, Poetry made it mandatory.

If you think it's worth an entry in the NEWS file, I will fill one.

Thank you very much.

@frostming
Copy link
Collaborator

Appreciated if you can do more changes:

  • Make truststore in its own group
  • Make copier and cookiecutter in their own groups, separately, and template group to contain both: pdm[copier,cookiecutter]
  • Change all to include all optional groups, by referencing the names.

@deronnax
Copy link
Sponsor Contributor Author

done. Tell me if it suits you.

pyproject.toml Outdated Show resolved Hide resolved
@frostming frostming merged commit bb5439f into pdm-project:main Jul 19, 2023
19 checks passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants