fix: Don't copy file permissions for templates #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
template-permissions
branch
2 times, most recently
from
171305c
to
3993858
Compare
|
LGTM! Would you please add a news fragment under |
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
When installing PDM through Nix (and other package managers with read-only file permissions) copying template permissions results in files which can't be used without chmod'ing them back to having write permissions. It's best that we just create the files as the user copying them with default permissions. Before: ``` $ pdm init $ ls -la total 16 drwx------ 6 adisbladis users 200 Nov 8 12:47 . drwxrwxrwt 56 root root 1580 Nov 8 12:49 .. -r--r--r-- 1 adisbladis users 3102 Jan 1 1970 .gitignore -rw-r--r-- 1 adisbladis users 36 Nov 8 12:47 .pdm-python drwxr-xr-x 2 adisbladis users 40 Nov 8 12:47 __pycache__ -rw-r--r-- 1 adisbladis users 215 Nov 8 12:47 pyproject.toml -r--r--r-- 1 adisbladis users 18 Jan 1 1970 README.md drwxr-xr-x 3 adisbladis users 60 Nov 8 12:47 src drwxr-xr-x 3 adisbladis users 80 Nov 8 12:47 tests drwxr-xr-x 4 adisbladis users 120 Nov 8 12:47 .venv ``` After: ``` $ pdm init $ ls -la total 16 drwx------ 5 adisbladis users 180 Nov 8 12:50 . drwxrwxrwt 56 root root 1580 Nov 8 12:49 .. -rw-r--r-- 1 adisbladis users 3102 Nov 8 12:50 .gitignore -rw-r--r-- 1 adisbladis users 69 Nov 8 12:50 .pdm-python drwxr-xr-x 2 adisbladis users 40 Nov 8 12:50 __pycache__ -rw-r--r-- 1 adisbladis users 215 Nov 8 12:50 pyproject.toml -rw-r--r-- 1 adisbladis users 18 Nov 8 12:50 README.md drwxr-xr-x 3 adisbladis users 60 Nov 8 12:50 src drwxr-xr-x 3 adisbladis users 80 Nov 8 12:50 tests ```
adisbladis
force-pushed
the
template-permissions
branch
from
3993858
to
f0efdce
Compare
Added. |
1 task
13 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing PDM through Nix (and other package managers with read-only file permissions) copying template permissions results in files which can't be used without chmod'ing them back to having write permissions.
It's best that we just create the files as the user copying them with default permissions.
Before:
After:
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.