Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new setting package-type to distinguish application and library #2394

Merged
merged 2 commits into from Nov 10, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

… library

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/pdm/cli/actions.py 81.28% <ø> (ø)
src/pdm/cli/commands/init.py 79.41% <100.00%> (+0.30%) ⬆️
src/pdm/cli/utils.py 81.94% <100.00%> (ø)
src/pdm/models/repositories.py 73.87% <100.00%> (-0.08%) ⬇️
src/pdm/project/core.py 89.39% <100.00%> (+0.07%) ⬆️
src/pdm/resolver/core.py 93.10% <100.00%> (ø)
src/pdm/cli/commands/add.py 87.50% <0.00%> (ø)
src/pdm/cli/commands/show.py 86.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit 15b9c10 into dev Nov 10, 2023
20 of 21 checks passed
@frostming frostming deleted the feat/package-type branch November 10, 2023 09:11
frostming added a commit that referenced this pull request Dec 1, 2023
frostming added a commit that referenced this pull request Dec 1, 2023
@deronnax
Copy link
Sponsor Contributor

This option is still undocumented 😢

@frostming
Copy link
Collaborator Author

This option is still undocumented 😢

yeah. But how would you like it to be documented and why not contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants