fix: resolve requirements paths relative to the requirement file they are specified in #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are specified in
mattem
force-pushed
the
relative_requirements_paths
branch
from
77684d4
to
f9eb961
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
==========================================
- Coverage 84.46% 84.45% -0.01%
==========================================
Files 102 102
Lines 10124 10125 +1
Branches 2225 2225
==========================================
Hits 8551 8551
- Misses 1095 1096 +1
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frostming
pushed a commit
that referenced
this pull request
Nov 23, 2023
… are specified in (#2422) Signed-off-by: Frost Ming <me@frostming.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
When the requirements parser encountered a
-rrequirements path reference it would pass the line directly toopen, whereas under pip (I was importing a requirements project when encountered this) the-rreferences are resolved relative to the file in which they are specified.This diff changes the behaviour to resolve the file relative to where it was specified, rather than the current working directory.