pdm init git@github.com:<USER>/<REPO>.git@<BRANCH_NAME> fails with <USER>/<REPO>.git@<BRANCH_NAME> is not a valid repository name

[logan-hcg]

• I have searched the issue tracker and believe that this is not a duplicate.

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

Run pdm init using a private repo and trying to check out a branch from Github.

pdm init git@github.com:<USER>/<REPO>.git@<BRANCH_NAME>

Actual behavior

Cloning into '<REPO>.git@<BRANCH_NAME>'...
fatal: remote error: 
 <USER>/<REPO>.git@<BRANCH_NAME>'is not a valid repository name
Visit https://support.github.com/ for help

Expected behavior

Should clone and checkout the template branch.

Environment Information

# Paste the output of `pdm info && pdm info --env` below:
PDM version:
  2.11.2
Python Interpreter:
  ~REDACTED~
Project Root:
  ~REDACTED~
Local Packages:
  
{
  "implementation_name": "cpython",
  "implementation_version": "3.10.13",
  "os_name": "posix",
  "platform_machine": "x86_64",
  "platform_release": "6.6.13-200.fc39.x86_64",
  "platform_system": "Linux",
  "platform_version": "#1 SMP PREEMPT_DYNAMIC Sat Jan 20 18:03:28 UTC 2024",
  "python_full_version": "3.10.13",
  "platform_python_implementation": "CPython",
  "python_version": "3.10",
  "sys_platform": "linux"
}

[logan-hcg]

I believe the issue is with the following code:

pdm/src/pdm/cli/templates/__init__.py

Lines 153 to 158 in e9ee590

	left, amp, right = url.rpartition("@")
	if left != "git" and amp:
	extra_args = [f"--branch={right}"]
	else:
	extra_args = []
	git_command = ["git", "clone", "--recursive", "--depth=1", *extra_args, url, self._path.as_posix()]

I believe it should be something like:

        left, amp, right = url.rpartition("@")
        if left != "git" and amp:
            extra_args = [f"--branch={right}"]
            # reset the clone URL to remove the branch reference that is being passed as the `--branch` argument
            url = left
        else:
            extra_args = []
        git_command = ["git", "clone", "--recursive", "--depth=1", *extra_args, url, self._path.as_posix()]

Thoughts?

[frostming]

I believe it should be something like:

Oh, right. Would you like to submit a PR?