Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self-referencing extra dependencies doesn't work for local packages #2898

Merged
merged 2 commits into from
May 24, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (533be5f) to head (ef813c0).
Report is 2 commits behind head on main.

Files Patch % Lines
src/pdm/models/repositories.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2898   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files         106      106           
  Lines       10596    10596           
  Branches     2307     2307           
=======================================
  Hits         9041     9041           
  Misses       1089     1089           
  Partials      466      466           
Flag Coverage Δ
unittests 85.10% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit 06d4592 into main May 24, 2024
22 of 24 checks passed
@frostming frostming deleted the fix/recursive-optional branch May 24, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant