Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: allow --abort-on-container-exit command option for up methods #105

Closed
lancerutkin opened this issue Mar 5, 2020 · 3 comments

Comments

@lancerutkin
Copy link
Contributor

Currently if I run an up method with the following command option:

commandOptions: ['--abort-on-container-exit']

I'll receive the following error message:

{ exitCode: 1, err: '-d cannot be combined with --abort-on-container-exit or --attach-dependencies.\n', out: '' }

This is because upAll, upMany, and upAll all always pass the -d flag.

To make --abort-on-container-exit usable we have it replace -d when the user passes --abort-on-container-exit as a commandOption.

Happy to open up a PR for this.

@AlexZeitler
Copy link
Contributor

AlexZeitler commented Mar 5, 2020 via email

@Steveb-p
Copy link
Contributor

Shouldn't this be closed?

@AlexZeitler
Copy link
Contributor

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants