Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions instead of CircleCI #113

Closed
AlexZeitler opened this issue May 8, 2020 · 1 comment · Fixed by #139
Closed

Use GitHub Actions instead of CircleCI #113

AlexZeitler opened this issue May 8, 2020 · 1 comment · Fixed by #139
Assignees
Labels

Comments

@AlexZeitler
Copy link
Contributor

AlexZeitler commented May 8, 2020

Why?

  • GitHub Actions should be good enough for us
  • Getting rid of additional tooling
@AlexZeitler
Copy link
Contributor Author

While working on this issue, I noticed there are several issues with our tests:

  • The alpine services are non-blocking which caused the tests to fail on CircleCI due to timing issues (the alpine services never needed to stop because they did stop on their own due to the lack of a blocking command running in the service). This can be fixed by e.g. using another nginx image instead of alpine.
  • The tests for --abort-on-container-exit option aren't able to stop/down the services which causes a timeout. I don't have a solution for this right now. @Steveb-p any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant