Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if map is not supported #53

Closed
crschnick opened this issue Jan 28, 2022 · 5 comments · Fixed by #56
Closed

Warn user if map is not supported #53

crschnick opened this issue Jan 28, 2022 · 5 comments · Fixed by #56
Labels
enhancement New feature or request

Comments

@crschnick
Copy link
Collaborator

In case the map is not supported (for whatever reason), we can show this information to the user on the front page already. We can check basic webgl requirements on the landing page, that doesn't require any resources.

@crschnick
Copy link
Collaborator Author

This could also included to check whether webgl2 is even supported

@nickbabcock
Copy link
Collaborator

webgl2 check already exists

if (!gl) {
setWarnings((x) => [...x, "WebGL2 not available"]);
} else if (maxTextureSize < requiredSize) {

@crschnick
Copy link
Collaborator Author

Add the context option failIfMajorPerformanceCaveat to this as well

@nickbabcock
Copy link
Collaborator

Done in af4cdbe

@crschnick
Copy link
Collaborator Author

We should also check if the amount of supported texture units in the fragment shader is >= 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants