-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use s3manager.BatchDelete #113
Comments
Seems like we cannot use s3manager.BatchDelete for this release. There are two different approaches to use s3manager.BatchDelete API.
This is fast but will not work since it removes the list result directly. We also need to remove keys that match with wildcard strings (not whole listing result). As an alternative, maybe we can write custom paginator (since it is an interface) and use this paginator on batch delete operations. But this does not reduce the complexity (I prefer our current architecture).
This is super easy and clean but slow. It won't perform well since it is required to list and collect all objects first and pass collected objects to That is why I am proposing to close this issue and remove from this milestone :) @igungor What do you think? You can close the issue if you agree. |
Thank you Onur. Not a blocker. Let's keep the issue open for a while. |
s3manager.BatchDelete does not provide any improvement over our solution. |
No description provided.
The text was updated successfully, but these errors were encountered: