Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse frame rates from HLS master playlists #448

Merged
merged 1 commit into from May 16, 2020

Conversation

glennguy
Copy link
Contributor

No description provided.

@peak3d peak3d merged commit 80c1bda into xbmc:Matrix May 16, 2020
@ksooo
Copy link
Member

ksooo commented May 17, 2020

With this PR applied, I see "23976.000 FPS" in Kodi's Player Info dialog for the first couple of seconds, before it changes to "23.976 FPS". Tested with Disney+, The Mandalorian, S1E1.

@glennguy
Copy link
Contributor Author

@ksooo could you please provide the url for the master hls playlist? Should be similar to eg. https://vod-l3c-oc-east-1.media.dssott.com/ps01/disney/60a600e8-1306-4118-b96b-b0b1f783871a/regular-ctr-sw-0579ca69-dccf-432a-b2d3-afa2cc49cb49.m3u8

@ksooo
Copy link
Member

ksooo commented May 17, 2020

http://vod-llc-eu-north-2.media.dssott.com/ps01/disney/60a600e8-1306-4118-b96b-b0b1f783871a/ctr-hdr10-high-7880964d-e657-4a0e-91a3-d2d2fd0344d2.m3u8

There is also an interesting line in my kodi.log:

2020-05-17 17:19:51.511 T:25296   ERROR: CVideoPlayerVideo::OpenStream - Invalid framerate 23976, using forced 25fps and just trust timestamps

@matthuisman
Copy link
Contributor

matthuisman commented May 17, 2020

In the playlist, its FRAME-RATE=23.976
I see in the code, that get's timed by 1000 (to remove decimals)
23.976*1000 = 23976
But I assume that's where the timescale is used to divide it later on by 1000?

glennguy added a commit to glennguy/inputstream.adaptive that referenced this pull request May 18, 2020
@glennguy
Copy link
Contributor Author

@ksooo thanks for that!
Found the issue, fixed in #451

@glennguy glennguy deleted the hls-frame-rate branch May 18, 2020 03:01
Maven85 pushed a commit to Maven85/inputstream.adaptive that referenced this pull request May 18, 2020
peak3d pushed a commit that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants