Add configuration option for using the public IP. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can still be overridden with the `-e` flag to `ssh`. The default isn't changed, so users have to explicitely add the option `use_public_ip` to their configuration file.
| if env["droplet_ip_private"] | ||
| use_public_ip = env["config"].use_public_ip | ||
|
|
||
| if not env["user_droplet_use_public_ip"].nil? |
There was a problem hiding this comment.
This is probably better as
unless env["user_droplet_use_public_ip"].nil? 
|
I've got two comments, but I'm going to fix them myself as a separate request so I can get all the PR's merged so we can get working v2 👍 |
petems
added a commit
that referenced
this pull request
Jan 31, 2015
Add configuration option for using the public IP.
|
Thanks @petems! |
|
No problem, thank you for your contribution @Ferada! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can still be overridden with the
-eflag tossh. The default isn't changed, so users have to explicitly add the optionuse_public_ipto their configuration file.I wasn't sure about whether it should also be added to the initial configuration file, so I have left that part out.
There is also one additional test case to verify the new configuration option.