Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecation defines added in tiff 4.3 headers. #128

Merged
merged 1 commit into from Oct 2, 2021

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jun 16, 2021

Without this fix the following error occurs:

('__attribute__((deprecated))', '#define TIFF_GCC_DEPRECATED __attribute__((deprecated))\n') name '__attribute__' is not defined
Traceback (most recent call last):
  File "/home/bob/git/pylibtiff/./test.py", line 3, in <module>
    import libtiff
  File "/home/bob/git/pylibtiff/libtiff/__init__.py", line 23, in <module>
    from .libtiff_ctypes import libtiff, TIFF, TIFF3D  # noqa: F401
  File "/home/bob/git/pylibtiff/libtiff/libtiff_ctypes.py", line 127, in <module>
    value = eval(value)
  File "<string>", line 1, in <module>
NameError: name '__attribute__' is not defined

@djhoese
Copy link
Collaborator

djhoese commented Sep 29, 2021

FYI I've included this patch downstream in the conda-forge conda package and it seems to be working just fine: conda-forge/pylibtiff-feedstock#8

I haven't helped maintain this library for years so I don't really feel comfortable merging this even though it seems I still have the permissions.

@robert-ancell
Copy link
Contributor Author

@nitschw do you have merge permissions?

@nitschw
Copy link

nitschw commented Oct 1, 2021

no :(

@pearu pearu merged commit 16dc6c2 into pearu:master Oct 2, 2021
@pearu
Copy link
Owner

pearu commented Oct 2, 2021

Thanks @robert-ancell for the fix!

@djhoese
Copy link
Collaborator

djhoese commented Oct 2, 2021

@pearu Thanks for merging this. Any idea if you'll have time for a release? When you do I can remove the patch I put in the conda-forge package.

@pearu
Copy link
Owner

pearu commented Oct 3, 2021

@djhoese I have created the release 0.4.4. Let me know if there are any problems with it.

@djhoese
Copy link
Collaborator

djhoese commented Oct 4, 2021

PyPI only shows 0.4.2 from 4 years ago: https://pypi.org/project/libtiff/

That's still the current name of the package on PyPI, right?

@pearu
Copy link
Owner

pearu commented Oct 4, 2021

Hmm, not sure why but 0.4.4 is now available as https://pypi.org/project/pylibtiff/0.4.4/

@pearu
Copy link
Owner

pearu commented Oct 4, 2021

libtiff was renamed to pylibtiff due to #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants