Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Music Control #25

Closed
matejdro opened this issue Oct 19, 2020 · 2 comments · Fixed by #83
Closed

Add Music Control #25

matejdro opened this issue Oct 19, 2020 · 2 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request question Further information is requested
Projects
Milestone

Comments

@matejdro
Copy link
Collaborator

matejdro commented Oct 19, 2020

Depends on #15

At the moment, there are two ways to do this on Android:

  • The old Bluetooth Intent way (like original Pebble app) - This allows user to pick one app in the settings (or on the watch) and always control that app. Big pro of this method is that user can start playback even when app is not active. Con is that many modern music players (such as Youtube Music or Google Podcasts) do not support that anymore, so user cannot control those apps.

  • New Notification Service way. This one is more modern and supports pretty much all media apps. Con of this is that it only controls last active app (user cannot switch between Podcasts and Spotify for example). Also this method has more information on playback (such as current position in track).

Which path should we take? I lean for for the second option.

@matejdro matejdro added the question Further information is requested label Oct 19, 2020
@matejdro matejdro added this to the Basics milestone Oct 21, 2020
@matejdro matejdro added the enhancement New feature or request label Oct 21, 2020
@matejdro matejdro self-assigned this Oct 28, 2020
@piggehperson
Copy link
Collaborator

Hm. I feel like I'm leaning towards notification service, as long as it can still handle things like the user switching media apps on the phone.

@matejdro
Copy link
Collaborator Author

I can add sort of hybrid approach I guess that would use notification service, but fall back to bluetooth intent to switch between apps. However, switching still wouldn't support many new apps.

@matejdro matejdro mentioned this issue Dec 24, 2020
@AliceGrey AliceGrey added this to Done in Android Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
No open projects
Android
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants