Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Website Link" shows up for apps that don't have a website #165

Closed
halkeye opened this issue Mar 9, 2020 · 2 comments · Fixed by #168
Closed

"Website Link" shows up for apps that don't have a website #165

halkeye opened this issue Mar 9, 2020 · 2 comments · Fixed by #168
Labels
Milestone

Comments

@halkeye
Copy link

halkeye commented Mar 9, 2020

CSS is broken because a tags without href are not considered links by browser, and thus wrong cursor

Clicking on it gives you a new link to "null"

Example: /#/app/5b02f29f461a8dd931000e5a

@sGerli sGerli added this to the V1.0.0-beta.4 milestone Mar 10, 2020
@sGerli sGerli added the bug label Mar 10, 2020
@mhelmetag
Copy link
Contributor

mhelmetag commented Sep 1, 2020

Would anyone be able to run a query on the DB to see if some website URLs are an empty string? It seems like they're usually null (so PG nil).

I think if this line is changed to either be just a null check or a blank and null check, that'll work. Whichever works better depending on the data (not sure if it's a field that has a validation against empty strings or just a free for all).

@mhelmetag
Copy link
Contributor

mhelmetag commented Sep 1, 2020

I think also any time it's an external link the cursor is technically wrong. Or at least that's what I'm seeing in a few places across the app. So I think those are two separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants