Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matmul, subtract, add function. #81

Closed
Ishwarendra opened this issue Feb 7, 2023 · 2 comments
Closed

Implement matmul, subtract, add function. #81

Ishwarendra opened this issue Feb 7, 2023 · 2 comments
Assignees

Comments

@Ishwarendra
Copy link
Collaborator

Ishwarendra commented Feb 7, 2023

  • Add function signature for each function inside the Matrix class in matrix.hpp and also implement in matrix.cpp.

  • Function specifications:

    • matmul: Multiplies two Matrices. A Matrix and a scalar is not allowed. Also throw appropriate exception if matrix dimension are not compatible for multiplication.
    • add: This function will have two overloads one which will add matrix and scalar and the other one for two matrices. Throw appropriate exceptions if matrix have incompatible dimensions.
    • subtract: Everything same as add function but you should do subtraction instead of addition.
  • Don't implement from scratch, use the already implemented functions operator +=, operator -= and operator *=. This way you will not have to worry about throwing appropriate exceptions as the already implemented function will do it for you.

  • Don't forget to add comments above each function signature you add in matrix.hpp. Avoid adding comments in matrix.cpp unless very important.

@Modernbeast02
Copy link
Contributor

I want to work on this. Plz assign it to me.

@Ishwarendra
Copy link
Collaborator Author

Assigned

Modernbeast02 added a commit to Modernbeast02/PWOC_slowmokit that referenced this issue Feb 7, 2023
uttammittal02 pushed a commit that referenced this issue Feb 8, 2023
* Resolved Issue #64

* Fixed All Operators Issue#64

* Resolved Issue#81

* Revert "Resolved Issue#81"

This reverts commit 16031e4.

* Resolved Issue #81

---------

Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
uttammittal02 pushed a commit that referenced this issue Feb 14, 2023
* Resolved Issue #64

* Fixed All Operators Issue#64

* Resolved Issue#81

* Revert "Resolved Issue#81"

This reverts commit 16031e4.

* Resolved Issue #81

* F1 Score #72

* Resolved #72

* Formatted Code

* f1Score.md

* Update f1Score.md

* Update f1Score.md

---------

Co-authored-by: Ishwarendra Jha <75680424+Ishwarendra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants