Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing paragraph about :form-params and keyword-params #87

Closed
terjesb opened this issue Aug 12, 2017 · 1 comment
Closed

Confusing paragraph about :form-params and keyword-params #87

terjesb opened this issue Aug 12, 2017 · 1 comment

Comments

@terjesb
Copy link

terjesb commented Aug 12, 2017

#57 cleaned up some confusion about keywordizing in :params (not by default) and :form-params (yes by default, when possible).

Just discovered that http://pedestal.io/reference/parameters still has a confusing paragraph around this:

One catch to note has to do with form parameters from an HTTP POST request. Because form fields can be named just about anything, the keys in these maps aren’t automatically converted to keywords. If you want them to be keywordized, you should make sure to have the keyword-params interceptor on the applicable route.

This is confusing as 1) :form-params (and :query-params) are now by default converted to keywords, when possible and 2) adding keyword-params would also keywordize :params, which by default are not keywordized.

Maybe simply remove this paragraph to avoid further confusion?

@terjesb terjesb changed the title Confusing paragraph about form-params and keyword-params Confusing paragraph about :form-params and keyword-params Aug 12, 2017
@ddeaguiar
Copy link
Contributor

Added clarifications to the Parameters reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants