feat(docz-core): add sourcemap config argument

doczjs · Dec 17, 2018 · 3baad4a · 3baad4a
1 parent 61a3050
commit 3baad4a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/docz-core/src/commands/args.ts b/packages/docz-core/src/commands/args.ts
@@ -66,6 +66,7 @@ export interface Argv {
   websocketHost: string
   native: boolean
   codeSandbox: boolean
+  sourcemaps: boolean
   /* template args */
   title: string
   description: string
@@ -198,4 +199,8 @@ export const args = (env: Env) => (yargs: any) => {
     type: 'boolean',
     default: getEnv('docz.codeSandbox', true),
   })
+  yargs.positional('sourcemaps', {
+    type: 'boolean',
+    default: getEnv('docz.sourcemaps', true),
+  })
 }
diff --git a/packages/docz-core/src/webpack/config.ts b/packages/docz-core/src/webpack/config.ts
@@ -126,7 +126,7 @@ export const createConfig = (args: Args, env: Env) => async (
    * loaders
    */
 
-  loaders.sourceMaps(config, args)
+  config.when(args.sourcemaps, cfg => loaders.sourceMaps(cfg, args))
   loaders.js(config, args)
   loaders.mdx(config, args)
   loaders.images(config)
@@ -170,9 +170,8 @@ export const createConfig = (args: Args, env: Env) => async (
       },
     })
 
-  config.when(isProd, cfg => minifier(cfg))
   config.performance.hints(false)
-
+  config.when(isProd, cfg => minifier(cfg, args))
   hooks.onCreateWebpackChain<Config>(config, !isProd, args)
   args.onCreateWebpackChain<Config>(config, !isProd, args)
 

diff --git a/packages/docz-core/src/webpack/minifier.ts b/packages/docz-core/src/webpack/minifier.ts
@@ -1,7 +1,9 @@
 import Config from 'webpack-chain'
 import * as TerserPlugin from 'terser-webpack-plugin'
 
-export const minifier = (config: Config) => {
+import { Config as Args } from '../commands/args'
+
+export const minifier = (config: Config, args: Args) => {
   config.optimization.minimizer('js').use(TerserPlugin, [
     {
       terserOptions: {
@@ -22,9 +24,9 @@ export const minifier = (config: Config) => {
           ascii_only: true,
         },
       },
-      cache: true,
       parallel: true,
-      sourceMap: true,
+      cache: !args.debug,
+      sourceMap: args.sourcemaps,
     },
   ])
 }