Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables can break in weird ways in default theme #342

Closed
wldcordeiro opened this issue Sep 19, 2018 · 12 comments
Closed

Tables can break in weird ways in default theme #342

wldcordeiro opened this issue Sep 19, 2018 · 12 comments
Labels
bug Something isn't working docz-default-theme Issues related to package docz-default-theme hacktoberfest

Comments

@wldcordeiro
Copy link

Bug Report

Describe the bug

This may be hard to solve and something that the all contribs table makes happen easier but it breaks in a really ugly way.

screen shot 2018-09-19 at 9 53 10 am

Expected behavior

I know it's doable to render nicer as the Gitlab readme page looks just fine.

screen shot 2018-09-19 at 9 56 00 am

@marceloavf
Copy link
Contributor

Hey @wldcordeiro, thanks for the report!

Do you have any code example, so I can take a look?

Thank you!

@pedronauck
Copy link
Member

@wldcordeiro how you're writing these tables? because the first line should be the table head, because that you're seeing this weird table...

@pedronauck pedronauck added the question Usage question or clarification request label Sep 20, 2018
@wldcordeiro
Copy link
Author

all contribs

It's generated so I don't control how it's written, you're even using the same tool to generate the table for yourself.

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore -->
| [<img src="https://gitlab.workfront.tech/uploads/-/system/user/avatar/21/avatar.png" width="100px;"/><br /><sub><b>Wellington Cordeiro</b></sub>](https://gitlab.workfront.tech/wellingtoncordeiro)<br />[💻](https://gitlab.workfront.tech/cnc/citadel/commits/master "Code") [📖](https://gitlab.workfront.tech/cnc/citadel/commits/master "Documentation") [👀](#review-wellingtoncordeiro "Reviewed Pull Requests") [🚇](#infra-wellingtoncordeiro "Infrastructure (Hosting, Build-Tools, etc)") [⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") [💬](#question-wellingtoncordeiro "Answering Questions") [🤔](#ideas-wellingtoncordeiro "Ideas, Planning, & Feedback") [🔧](#tool-wellingtoncordeiro "Tools") | [<img src="https://secure.gravatar.com/avatar/ee753868e0b47160c949c61e2b38d49d?s=80&d=identicon" width="100px;"/><br /><sub><b>Jared Nyman</b></sub>](https://gitlab.workfront.tech/jarednyman)<br />[💻](https://gitlab.workfront.tech/cnc/citadel/commits/master "Code") [👀](#review-jarednyman "Reviewed Pull Requests") [⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") [💬](#question-jarednyman "Answering Questions") [🤔](#ideas-jarednyman "Ideas, Planning, & Feedback") [📖](https://gitlab.workfront.tech/cnc/citadel/commits/master "Documentation") | [<img src="https://gitlab.workfront.tech/uploads/-/system/user/avatar/97/avatar.png" width="100px;"/><br /><sub><b>Lance Wintch</b></sub>](https://gitlab.workfront.tech/lancewintch)<br />[💻](https://gitlab.workfront.tech/cnc/citadel/commits/master "Code") [👀](#review-lancewintch "Reviewed Pull Requests") [⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") [💬](#question-lancewintch "Answering Questions") [🤔](#ideas-lancewintch "Ideas, Planning, & Feedback") [📖](https://gitlab.workfront.tech/cnc/citadel/commits/master "Documentation") |
| :---: | :---: | :---: |
| [<img src="https://gitlab.workfront.tech/uploads/-/system/user/avatar/20/avatar.png" width="100px;"/><br /><sub><b>Jarvis</b></sub>](https://gitlab.workfront.tech/jarvis)<br />[🚇](#infra-jarvis "Infrastructure (Hosting, Build-Tools, etc)") | [<img src="https://secure.gravatar.com/avatar/e7a39d23ff95ffa1d114f554c87cf9b1?s=80&d=identicon" width="100px;"/><br /><sub><b>Tyler Rasmussen</b></sub>](https://gitlab.workfront.tech/tylerrasmussen)<br />[💻](https://gitlab.workfront.tech/cnc/citadel/commits/master "Code") [⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") | [<img src="https://secure.gravatar.com/avatar/591f3464a71583a2276a41cb61704c3b?s=80&d=identicon" width="100px;"/><br /><sub><b>Andrew Grange</b></sub>](https://gitlab.workfront.tech/andrewgrange)<br />[💻](https://gitlab.workfront.tech/cnc/citadel/commits/master "Code") [⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") |
| [<img src="https://secure.gravatar.com/avatar/6486bbfc2cf45c16bc824a3f61027b5c?s=80&d=identicon" width="100px;"/><br /><sub><b>Eric Merrill</b></sub>](https://gitlab.workfront.tech/ericmerrill)<br />[💻](https://gitlab.workfront.tech/cnc/citadel/commits/master "Code") [⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") [👀](#review-ericmerrill "Reviewed Pull Requests") | [<img src="https://secure.gravatar.com/avatar/efc62d4aa33489e5c2b7bdf8b1241924?s=80&d=identicon" width="100px;"/><br /><sub><b>Niti Guru</b></sub>](https://gitlab.workfront.tech/nitiguru)<br />[⚠️](https://gitlab.workfront.tech/cnc/citadel/commits/master "Tests") |
<!-- ALL-CONTRIBUTORS-LIST:END -->

@marceloavf
Copy link
Contributor

It seems to be acting normally as the code says to center after the fist line, but github/gitlab don't that, strange, maybe a bug with the md compiler or all contributors list?

@halvardlange
Copy link

I have the same issue - it seems that Docz always left-adjusts the header of a table in markdown - which I don't think is the standard when using markdown (i.e. centered column should center header too.) Maybe it can be fixed in the theme?

@pedronauck pedronauck added bug Something isn't working docz-default-theme Issues related to package docz-default-theme and removed question Usage question or clarification request labels Sep 27, 2018
@IssueHuntBot
Copy link

@BoostIO funded this issue with $20. Visit this issue on Issuehunt

@marceloavf
Copy link
Contributor

image

That's what you want @wldcordeiro ?

@wldcordeiro
Copy link
Author

@marceloavf Yep that's right!

@IssueHuntBot
Copy link

@marceloavf has started working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@marceloavf has submitted output. Visit this issue on Issuehunt

@marceloavf
Copy link
Contributor

Fixed in #403 and released in v0.12.7

@IssueHuntBot
Copy link

@pedronauck has rewarded $14.00 to @marceloavf. See it on IssueHunt

  • 💰 Total deposit: $20.00
  • 🎉 Repository reward(20%): $4.00
  • 🔧 Service fee(10%): $2.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docz-default-theme Issues related to package docz-default-theme hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants