Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quitting the dev process does not actually stop the server #350

Closed
kentcdodds opened this issue Sep 21, 2018 · 8 comments
Closed

Quitting the dev process does not actually stop the server #350

kentcdodds opened this issue Sep 21, 2018 · 8 comments
Labels
bug Something isn't working difficult: high docz-core Issues related to package docz-core help wanted Extra attention is needed

Comments

@kentcdodds
Copy link
Contributor

Bug Report

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

I'm not 100% how to reproduce this reliably. You could try starting docz and before it finishes starting, try to stop it (+c). It doesn't stop and continues to try to compile.

I'm fairly certain that this also happens when it's been running. Maybe only when it's recompiling.

In order to allow us to quickly reproduce you issue please include a link to a reproduction repository.

Sorry, closed source :-(

Expected behavior

A clear and concise description of what you expected to happen..

I expect quitting the process to close all spawned subprocesses.

Environment

  • OS: macOS High Sierra 10.13.6
  • Node/npm version: Node 8/npm 6
@nicholasess nicholasess added bug Something isn't working good first issue Good for newcomers and removed good first issue Good for newcomers labels Sep 22, 2018
@pedronauck
Copy link
Member

Hi @kentcdodds, thanks to the report. I'm investigating what's happening and I think that is something related to happypack because it's threads or webpack-serve around the dev server. I'll check this 🙏

@pedronauck pedronauck added difficult: high docz-core Issues related to package docz-core help wanted Extra attention is needed labels Sep 27, 2018
@IssueHuntBot
Copy link

@BoostIO funded this issue with $40. See it on IssueHunt

@IssueHuntBot
Copy link

@pedronauck has started working. See it on IssueHunt

@IssueHuntBot
Copy link

@pedronauck has rewarded. See it on IssueHunt

@pedronauck
Copy link
Member

Fixed, will be release in the next version!

@kentcdodds
Copy link
Contributor Author

Thank you!

@kentcdodds
Copy link
Contributor Author

By the way, I've been using docz a lot lately and I really love it. Thank you for your work here!

@pedronauck
Copy link
Member

pedronauck commented Nov 15, 2018

Thanks @kentcdodds, I was a little bit distant from docz in the last months because some personal issues, but now I came back and trying to work more frequently here again. If you have any feedback or bug report, please, talk with me dude 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficult: high docz-core Issues related to package docz-core help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants