Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could there be an option that allows Playground to take as many lines as it needs? #362

Closed
drcmda opened this issue Sep 25, 2018 · 6 comments
Labels
difficult: medium docz-default-theme Issues related to package docz-default-theme enhancement IssueHuntFest Label for Issue Hunt Festival 2018

Comments

@drcmda
Copy link

drcmda commented Sep 25, 2018

Currently it limits it to 14 lines, which makes examples sometimes really hard to glance over. I wish it wouldn't do that and instead take up as many lines as it needs, even if it takes a full page. Often what the user sees at first isn't the actual example, but preparation code that shouldn't be the focus.

Here's an example: http://react-spring.surge.sh/native (scroll down to "Animating scroll position"), what you see isn't the primary part i'd like to teach there, it's just initial boilerplate, the actual example starts with line 17.

@drcmda
Copy link
Author

drcmda commented Sep 25, 2018

After mucking around with it for a while i've found a hack:

htmlContext: {
  head: {
    raw: `
      <style>
        .scrollbar-container {
          max-height: unset!important;
        }
      </style>
    `
  },
},

The issue could be closed, unless you want to make it a Playground.prop (?)

@pedronauck
Copy link
Member

For sure, that's a good idea, I'll make this change and put it in the release v0.12.0 🙏

@pedronauck pedronauck added difficult: medium docz-default-theme Issues related to package docz-default-theme enhancement labels Sep 27, 2018
@pedronauck pedronauck added the IssueHuntFest Label for Issue Hunt Festival 2018 label Dec 4, 2018
@IssueHuntBot
Copy link

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt

@IssueHuntBot
Copy link

@pedronauck has submitted a pull request. See it on IssueHunt

@IssueHuntBot
Copy link

@pedronauck has rewarded $28.00 to @pedronauck. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(20%): $8.00
  • 🔧 Service fee(10%): $4.00

@pedronauck
Copy link
Member

Launched on v0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficult: medium docz-default-theme Issues related to package docz-default-theme enhancement IssueHuntFest Label for Issue Hunt Festival 2018
Projects
None yet
Development

No branches or pull requests

3 participants