Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also publish non-minified code to npm #413

Closed
danielberndt opened this issue Oct 16, 2018 · 6 comments
Closed

Also publish non-minified code to npm #413

danielberndt opened this issue Oct 16, 2018 · 6 comments
Labels
enhancement good first issue Good for newcomers IssueHuntFest Label for Issue Hunt Festival 2018

Comments

@danielberndt
Copy link

First off, thanks a ton for making documenting a really pleasant experience! 馃憤

I just stumbled across an potential issue (order within a menu doesn't work as expected in my project) and wanted to dig into the source code via placing some console.logs at the relevant place in my node_modules. This is made very difficult though since all the files are minified. I understand that it's nice to have a minified version for people who want to use e.g. unpkg, but I haven't seen many projects where the actual required files are minified as well.

@transitive-bullshit
Copy link
Contributor

馃挴

Instead of publishing both minified and non-minified versions, though, docz should only publish non-minified, transpiled ES5-compatible sources with source maps enabled.

I've previously written about why library authors should have their package.json main and / or module fields point to unminified files.

@nicholasess nicholasess added the question Usage question or clarification request label Nov 25, 2018
@pedronauck pedronauck added good first issue Good for newcomers and removed question Usage question or clarification request labels Dec 4, 2018
@pedronauck
Copy link
Member

For sure @transitive-bullshit, since docz and docz-theme-default and bundle and minified using webpack on docz build, I think that isn't necessary to minify these codes before 鉁岋笍

@pedronauck pedronauck added enhancement IssueHuntFest Label for Issue Hunt Festival 2018 labels Dec 4, 2018
@IssueHuntBot
Copy link

@issuehuntfest has funded $30.00 to this issue. See it on IssueHunt

@IssueHuntBot
Copy link

@pedronauck has submitted a pull request. See it on IssueHunt

@IssueHuntBot
Copy link

@pedronauck has rewarded $21.00 to @pedronauck. (Total deposit: $30.00, Repository reward(20%): $6.00, Service fee(10%): $3.00) See it on IssueHunt

@Glazy
Copy link
Contributor

Glazy commented Mar 29, 2019

Hey @pedronauck,

I see that @IssueHuntBot has rewarded you for this - did you manage to put a fix in place so we can close the issue? 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good for newcomers IssueHuntFest Label for Issue Hunt Festival 2018
Projects
None yet
Development

No branches or pull requests

7 participants