base shouldn't be conditional

[ericclemmons]

Bug Report

base only affects the public path in production, where it should exist in all environments (especially when using Docz behind a proxy in a larger app!)

Describe the bug

https://github.com/pedronauck/docz/blob/daa1c89b5b033e323df06c18c40e7ac50aaad3bd/packages/docz-core/src/webpack/config.ts#L25

To Reproduce

1. Set doczrc.js to contain:

export default {
  base: '/docz/'
}

2. yarn docz dev
3. Notice how assets are still http://localhost:3000/static/js/app.js, and not prefixed by /docz/.

Expected behavior

I expected /docz/ to be consistent across all environments.

If people want it disabled in development, doczrc.js can contain:

export default {
  base: process.env.NODE_ENV === "production" ? "/docz/" : null
}

Environment

node -e "var os=require('os');console.log('Node.js ' + process.version + '\n' + os.platform() + ' ' + os.release())"
npm --version

Node.js v10.13.0
darwin 18.2.0
6.4.1

[ericclemmons]

I can PR this if it's acceptable!

[ericclemmons]

This looks doable now!

https://www.docz.site/docs/project-configuration#basic-config