Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docz-core): writeApp before setting up the server and create db.json #216

Closed

Conversation

dariocravero
Copy link

@dariocravero dariocravero commented Aug 13, 2018

Description

Fix a regression introduced by the caching layer in DataServer trying to read app/db.json when starting a new project since the .docz folder doesn't exist until writeApp is called.

Review

  • Is moving Entries.writeApp right after newConfig is defined ok (see change)?
  • Is re-creating db.json ok (see change)?

Pre-merge checklist

N/A?

Screenshots

N/A

@pedronauck
Copy link
Member

Hi dude, sorry but I see just now your pull request and I was already fixing this issue, was landed in v0.10.1 🙏

@pedronauck pedronauck closed this Aug 13, 2018
@dariocravero
Copy link
Author

no worries, glad it's fixed, thanks man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants