Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make react/react-dom peer dependencies #882

Conversation

saimonmoore
Copy link

@saimonmoore saimonmoore commented May 20, 2019

Description

docz has a direct dependency on react/react-dom which very often conflicts with other dependencies in apps that also have direct dependencies on react/react-dom.

Screenshot 2019-05-17 at 16 40 14

In this PR, we make react & react-dom peer dependencies.

Review

  • Check it's all still working.

Pre-merge checklist

  • ???

Screenshots

Before After
Image Image

@saimonmoore saimonmoore force-pushed the make-react-react-dom-peer-dependencies branch from bf17732 to 7362ae5 Compare May 20, 2019 12:59
@draperunner
Copy link

But don't you need to remove the direct dependencies? Check core/docz/package.json. It has react and react-dom under both dependencies and peerDependencies. Same goes for docz-theme-default. gatsby-theme-docz has them under dependencies, but no peerDependencies. I'd guess you needed to remove the direct dependencies for these subpackages.

Also, you should update the installation instructions in README.md, adding a mention that react and react-dom has to be installed explicitly.

@saimonmoore
Copy link
Author

@draperunner true. Will update.

@pedronauck
Copy link
Member

Already merged into feat/gatsby.

@pedronauck pedronauck closed this Jul 11, 2019
@draperunner draperunner mentioned this pull request Jul 18, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants