Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is missing alt #37

Open
sebqq opened this issue Jul 27, 2020 · 3 comments
Open

Image is missing alt #37

sebqq opened this issue Jul 27, 2020 · 3 comments
Labels
enhancement New feature or request legacy v2

Comments

@sebqq
Copy link

sebqq commented Jul 27, 2020

Hello.

First of all, thank you for this lib. I keep getting following error message in my console:

Warning: Failed prop type: The prop `alt` is marked as required in `Image`, but its value is `null`.
    in Image (created by Thumbnail)
    in Thumbnail (created by Caption)
    in li (created by Caption)

What can I do with it?
Thanks!

@sebqq
Copy link
Author

sebqq commented Jul 27, 2020

Solved by providing caption param.

But what if there is no caption to display? I don't want to display image name as caption. there should be something like alt and thumbnailAlt props in Photo type.

@sebqq sebqq closed this as completed Jul 27, 2020
@pedropalau
Copy link
Owner

Hey @sebqq, thanks your interest in this project.

I like the point you mention, it might be useful to have a different param for the alt attribute of images and use the caption parameter by default.

So, I think I going to reopen this one to work on it.

@pedropalau pedropalau reopened this Jul 27, 2020
@apepper
Copy link

apepper commented Sep 15, 2020

An alt attribute for photos that is used as the alt attribute on rendered <img> would be really appreciated.

@pedropalau pedropalau added enhancement New feature or request v2 legacy labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request legacy v2
Projects
None yet
Development

No branches or pull requests

3 participants