Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JUnit vintage tests and add vintage engine #55

Merged
merged 1 commit into from Oct 4, 2019

Conversation

tonilopezmr
Copy link

@tonilopezmr tonilopezmr commented Oct 1, 2019

馃搶 References

馃帺 What is the goal?

馃摑 How is it being implemented?

  • Upgrade gradlew version
  • Replaced compile to implementation method
  • Add JUnit Vintage engine which is responsible to run find and run JUnit 4 tests, this error was introduced in the last commit of the PR Add JUnit 5 support聽#52

馃挜 How can it be tested?

  • Now in Travis runs all JUnit tests

I'd like to improve the Travis output because I can't see the test output easily

@tonilopezmr tonilopezmr changed the title Fix JUnit vintage tests adding vintage engine Fix JUnit vintage tests and adding vintage engine Oct 1, 2019
@tonilopezmr tonilopezmr changed the title Fix JUnit vintage tests and adding vintage engine Fix JUnit vintage tests and add vintage engine Oct 1, 2019
Copy link
Owner

@pedrovgs pedrovgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tonilopezmr. I've tested this branch manually and it works like a charm. I can see a new screenshot I was missing in the original PR where that test was added.

@pedrovgs
Copy link
Owner

pedrovgs commented Oct 4, 2019

I'm going to merge this PR because the author of the PR is one of our core committers, @Serchinastico is out for holidays and @flipper83 he's busy with other tasks.

@pedrovgs pedrovgs merged commit e182d7d into master Oct 4, 2019
@pedrovgs pedrovgs deleted the fix-junit-vintage branch October 4, 2019 06:16
@tonilopezmr
Copy link
Author

Thanks!! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants