Update dependencies Issue#44 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you so much for your contribution @marcbenedi 😃 As you can see here the build is not passing because you've updated the build tools but not the Travis CI configuration file to use this android build tools library version. Could you please update the Travis configuration so we use Android 28 and we can see the build passing before merging this PR? |
|
Hi @pedrovgs, thank you for your feedback! I pushed a new commit with the build-tools updated and the build is passing. |
|
Thank you so much for your contribution @marcbenedi 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pedrovgs!
As indicated in Issue#44 , I updated the dependencies and adapted the code to the corresponding API changes.
The only dependency which hasn't been updated to the latest version is ButterKnife. It was causing conflicts with androidX and it required minSdk Android N.
I hope it this is useful!
Cheers.
This closes #44