Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shot doesn't work with API 23+ devices #35

Closed
AOrobator opened this issue Jan 28, 2018 · 3 comments
Closed

Shot doesn't work with API 23+ devices #35

AOrobator opened this issue Jan 28, 2018 · 3 comments
Assignees

Comments

@AOrobator
Copy link

Expected behaviour

Screenshot tests run on API 23+

Actual behaviour

        java.lang.RuntimeException: This does not currently work on API 23+, see https://github.com/facebook/screenshot-tests-for-android/issues/16 for details.
        at com.facebook.testing.screenshot.internal.ScreenshotDirectories.checkPermissions(ScreenshotDirectories.java:38)

Steps to reproduce

run ./gradlew executeScreenshotTests -Precord

Version of the library

1.0.0

Just a note, the facebook screenshot library now supports API 23+

facebook/screenshot-tests-for-android#89

@pedrovgs
Copy link
Owner

Thanks for reporting @AOrobator. As the latest Facebook release is recent I did not see this feature. I'll update Shot to support this feature for sure 😃

@pedrovgs
Copy link
Owner

pedrovgs commented Feb 9, 2018

Fixed! I'm going to release a new version today @AOrobator

@pedrovgs
Copy link
Owner

pedrovgs commented Feb 9, 2018

Thanks @tonilopezmr and @Serchinastico 😃

@pedrovgs pedrovgs closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants