Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error:Configuration with name 'androidTestImplementation' not found. #25

Closed
CristianGM opened this issue Nov 2, 2017 · 6 comments
Closed

Comments

@CristianGM
Copy link

Expected behaviour

When using the Android gradle plugin <3.0 the plugin should use androidTestCompile

Actual behaviour

it's adding androidTestImplementation so it doesn't compile

The issue seems to be in that function
https://github.com/Karumi/Shot/blob/adeef269ab719ffa776b96d50d7928c0c2b96fa8/shot/src/main/scala/com/karumi/shot/ShotPlugin.scala#L82

Steps to reproduce

Apply the plugin to a project using Gradle 4.2.1 but Android plugin 2.3.3

Version of the library

0.3.0

@flipper83
Copy link
Contributor

@CristianGM can you share with me in the gradle.properties thebuild:gradle? is 2.3.3 ??

@CristianGM
Copy link
Author

In the build.gradle I have:
classpath 'com.android.tools.build:gradle:2.3.3'

but in the gradle-wrapper.properties

#Wed Oct 18 17:13:00 CEST 2017
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.2.1-all.zip

The issue is the new implementation/api dependencies comes with the 'com.android.tools.build:gradle:3.+' not with the gradle wrapper you are checking.

@pedrovgs
Copy link
Owner

Sorry for the delay @CristianGM, but I've been out for holidays 🛫 Could you paste a link to the Gradle Android Plugin changelog so we can review if the breaking change was added in this version or a different one? @flipper83 reviewed the version number when implementing the feature and if it was applied in the Android Plugin or Gradle twice, but it was long ago and I don't remember the numbers. If you could provide the links I'll personally fix the issue for the next version. Thank you in advance 😃

@pedrovgs
Copy link
Owner

pedrovgs commented Feb 9, 2018

@CristianGM could you review this issue you opened? I'd really like to fix it but I need the information I requested you in my previous comment 😃

@CristianGM
Copy link
Author

I did move to AGP 3.0 so I don't have the issue anymore.
I could simply close the issue, also I don't expect many people will use AGP 2.3.x , fixing it would be just for correctness.

@pedrovgs
Copy link
Owner

Ok, thanks! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants