NPE recording screenshots #70

slacklab · 2019-10-24T15:45:12Z

I want to run yours plugin
I do:
./gradlew executeScreenshotTests -Precord

But get some errors:

⬇️  Pulling screenshots from your connected devices!

> Task :presentation:executeScreenshotTests FAILED
💾  Saving screenshots.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':presentation:executeScreenshotTests'.
> java.io.FileNotFoundException: /Users/ivan/AndroidStudioProjects/android-client/presentation/screenshots/screenshots-default/com.kg.project.presentation.RegressSuite_test_dump.json (No such file or directory)

But I found this Json at zip archive screenshot_bundle.zip

What I should do to avoid this error?

Thanks in advance

Version of the library

com.karumi:shot:3.0.2

The text was updated successfully, but these errors were encountered:

tonilopezmr · 2019-10-24T16:32:24Z

Can you share more information about your build.gradle with your configuration?
Or share a complete example to reproduce the error?

Thanks!!

slacklab · 2019-10-25T07:44:13Z

@tonilopezmr
in build.gradle(Project)

classpath 'com.karumi:shot:3.0.2'

in app/build.gradle(Module)

 // Standard Android View Plugins (TextView, etc)
    implementation "com.facebook.testing.screenshot:layout-hierarchy-common:0.11.0"

    // Litho Component Plugins
    implementation "com.facebook.testing.screenshot:layout-hierarchy-litho:0.11.0"

shot {
    appId = 'com.kg.project'
    instrumentationTestTask = 'connectedDevDebugAndroidTest'
}

// setup for facebook screenshot plugin
screenshots {
    referenceDir = "$projectDir/build/outputs/screenshots"
    multipleDevices true
}

Can you give me some advice?

tonilopezmr · 2019-10-25T13:09:56Z

Thanks! @slacklab, during next month we will take a look at this issue to solve it, in the meantime, if you have more informatión to share or you found the solution and want to make a PR with the fix is more than welcome.

pedrovgs · 2019-10-25T13:36:31Z

@slacklab could you please ensure you are not adding this dependency to your build.gradle file? com.facebook.testing.screenshot:core The error you reported is generated because any part of your code is importing that dependency with a version greater than 0.8.0 which is the last version we support right now. Could you check your dependencies and let me know if this facebook dependency is declared?

If the dependency is not declared, could you please run ./gradlew app:dependencies and paste the output of the command in a comment?

pedrovgs · 2019-10-25T13:37:59Z

Please, try also to remove these dependencies you declared in your manifest if my previous comment didn't fix the issue.

    // Standard Android View Plugins (TextView, etc)
    implementation "com.facebook.testing.screenshot:layout-hierarchy-common:0.11.0"

    // Litho Component Plugins
    implementation "com.facebook.testing.screenshot:layout-hierarchy-litho:0.11.0"

ivan399 · 2019-10-28T11:01:46Z

@pedrovgs

Hello !

If you remove this dependence - the test will fail with such an error.

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at com.facebook.testing.screenshot.internal.ScreenshotImpl.runCallableOnUiThread(ScreenshotImpl.java:335)
at com.facebook.testing.screenshot.internal.ScreenshotImpl.storeBitmap(ScreenshotImpl.java:157)
at com.facebook.testing.screenshot.internal.ScreenshotImpl.record(ScreenshotImpl.java:261)
at com.facebook.testing.screenshot.internal.RecordBuilderImpl.record(RecordBuilderImpl.java:155)
at com.myapp.present.Suite.test(Suite.kt:417)
at java.lang.reflect.Method.invoke(Native Method)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at androidx.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:134)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at androidx.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:531)
at androidx.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:134)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:392)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1955)
Caused by: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at com.facebook.testing.screenshot.WindowAttachment.invokeUnchecked(WindowAttachment.java:103)
at com.facebook.testing.screenshot.WindowAttachment.invoke(WindowAttachment.java:94)
at com.facebook.testing.screenshot.WindowAttachment.dispatchAttach(WindowAttachment.java:83)
at com.facebook.testing.screenshot.internal.ScreenshotImpl.storeBitmap(ScreenshotImpl.java:173)
at com.facebook.testing.screenshot.internal.ScreenshotImpl.access$000(ScreenshotImpl.java:47)
at com.facebook.testing.screenshot.internal.ScreenshotImpl$2.call(ScreenshotImpl.java:161)
at com.facebook.testing.screenshot.internal.ScreenshotImpl$2.call(ScreenshotImpl.java:158)
at com.facebook.testing.screenshot.internal.ScreenshotImpl$3.run(ScreenshotImpl.java:317)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6394)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1000)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:890)
Caused by: java.lang.reflect.InvocationTargetException
at java.lang.reflect.Method.invoke(Native Method)
at com.facebook.testing.screenshot.WindowAttachment.invokeUnchecked(WindowAttachment.java:101)
... 14 more
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.ViewRootImpl.addWindowCallbacks(android.view.WindowCallbacks)' on a null object reference
at com.android.internal.policy.DecorView.onAttachedToWindow(DecorView.java:1566)
... 16 more

./gradlew app:dependencies

What lines are interested in this command? In the output did not find Facebook dependencies

pedrovgs · 2019-10-28T11:25:30Z

@ivan399 I'm afraid looking at the trace I don't understand where the NPE comes from. Could you please upload a zip file or create a GitHub repository with a reproducing the error?

ivan399 · 2019-10-29T06:32:33Z

@pedrovgs

I don’t have the right to publicly upload a project or part of it :(

But I found a similar problem: facebook/screenshot-tests-for-android#68

pedrovgs · 2019-10-29T07:49:52Z

@ivan399 I don't mean uploading the code of the app you are working on right now. I mean uploading any sample project you could create reproducing the error.

emilioscy · 2020-01-21T08:13:34Z

Here is a test project that produces this specific error.
https://github.com/emilioscy/MFSNapshotTest

Serchinastico · 2020-01-21T13:45:18Z

Hi @emilioscy, I'm seeing your project has both, Shot and Facebook's Screenshot library included. This will override the dependency Shot is using internally and will produce strange behaviors. I recommend not mixing both and stick to one of them.

emilioscy · 2020-01-22T07:14:42Z

Hello @Serchinastico, i removed Facebook's library and works as expected. Perhaps this is what was causing the issue for @slacklab.

Serchinastico · 2020-01-28T07:22:46Z

I'm closing the issue. There is already a small section on the README describing problems if you load your own facebook dependency and how the current version of Shot is only compatible with FB's 0.8.0

pedrovgs changed the title ~~Cannot run any compare snapshots~~ NPE recording screenshots Nov 8, 2019

pedrovgs added bug help wanted labels Nov 8, 2019

Serchinastico closed this as completed Jan 28, 2020

eyalgu mentioned this issue Mar 4, 2020

Saving screenshots fails if RecordBuilder#setName was set with a name that contains whitespaces #88

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPE recording screenshots #70

NPE recording screenshots #70

slacklab commented Oct 24, 2019 •

edited

Loading

tonilopezmr commented Oct 24, 2019

slacklab commented Oct 25, 2019 •

edited

Loading

tonilopezmr commented Oct 25, 2019

pedrovgs commented Oct 25, 2019

pedrovgs commented Oct 25, 2019

ivan399 commented Oct 28, 2019 •

edited by pedrovgs

Loading

pedrovgs commented Oct 28, 2019

ivan399 commented Oct 29, 2019 •

edited

Loading

pedrovgs commented Oct 29, 2019

emilioscy commented Jan 21, 2020

Serchinastico commented Jan 21, 2020

emilioscy commented Jan 22, 2020

Serchinastico commented Jan 28, 2020

NPE recording screenshots #70

NPE recording screenshots #70

Comments

slacklab commented Oct 24, 2019 • edited Loading

Version of the library

tonilopezmr commented Oct 24, 2019

slacklab commented Oct 25, 2019 • edited Loading

tonilopezmr commented Oct 25, 2019

pedrovgs commented Oct 25, 2019

pedrovgs commented Oct 25, 2019

ivan399 commented Oct 28, 2019 • edited by pedrovgs Loading

pedrovgs commented Oct 28, 2019

ivan399 commented Oct 29, 2019 • edited Loading

pedrovgs commented Oct 29, 2019

emilioscy commented Jan 21, 2020

Serchinastico commented Jan 21, 2020

emilioscy commented Jan 22, 2020

Serchinastico commented Jan 28, 2020

slacklab commented Oct 24, 2019 •

edited

Loading

slacklab commented Oct 25, 2019 •

edited

Loading

ivan399 commented Oct 28, 2019 •

edited by pedrovgs

Loading

ivan399 commented Oct 29, 2019 •

edited

Loading