Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work for form elements #64

Closed
oskarrough opened this issue Apr 4, 2016 · 0 comments
Closed

Doesn't work for form elements #64

oskarrough opened this issue Apr 4, 2016 · 0 comments

Comments

@oskarrough
Copy link

Hi, as <form> elements have a length they can't be used as Wallop containers because of this:

if (selector.length > 0) {  
  throw new Error('Selector cannot be an array, Refer to Usage documentation: https://github.com/peduarte/wallop#javascript');
} else {
  this.$selector = selector;
}

Any thoughts how we could like to deal with it? Something like if (selector.tagName !== 'FORM' && selector.length > 0) { perhaps?

Great module by the way, works really well otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant