Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative urls everywhere #154

Open
olizilla opened this issue May 2, 2018 · 0 comments
Open

Use relative urls everywhere #154

olizilla opened this issue May 2, 2018 · 0 comments

Comments

@olizilla
Copy link
Collaborator

olizilla commented May 2, 2018

Once nice feature of the deploy set up is that it publishes a snapshot of the built site to ipfs for evey commit, like: https://ipfs.io/ipfs/QmbC54Bshtcgr1ndX3zWdecbCoZdRujvuxXrkqhmcGKx5P/#/

For a site to work as expected when deployed under https://peerpad.net/ and under an ipfs path like /ipfs/QmHash, we have to use relative urls everywhere!

There are a few urls in peer-pad now that are absolute so they fail to load when viewing the site via its ipfs address:

screenshot 2018-05-02 15 24 32

As a side note... It'd be rad to set up a generic CI step that renders the site and checks for absolute urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant