Windows Filename issue #77
Conversation
|
Okay, I did not know ":" is illegal in Windows. |
|
Welp, it seems this nuked all the tests. I would guess you have corrupted the datasets. |
|
I only changed the filenames? Both the filename and the line in code that refers to them. |
|
Upon further inspection it seems your PSAR commit is what is nuking the tests. I am digging in to see what is going on. Give it a try maybe you spot what is going on. |
|
I closed pull request #76 as I am still working on the PSAR function. Due to the nature of how PSAR is calculated the function will need further tweaking. I didn't have time to tweak it, can we revert the PSAR commit for now? I'll open another PR when finished tweaking the function and tested properly (next few days hopefully). |
|
Just push patch onto master when done. |
$ git clone https://github.com/peerchemist/finta
Cloning into 'finta'...
remote: Enumerating objects: 160, done.
remote: Counting objects: 100% (160/160), done.
remote: Compressing objects: 100% (109/109), done.
remote: Total 1227 (delta 84), reused 112 (delta 49), pack-reused 1067
Receiving objects: 100% (1227/1227), 522.49 KiB | 1.59 MiB/s, done.
Resolving deltas: 100% (657/657), done.
error: invalid path 'tests/data/bittrex:btc-usdt.csv'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
Colon (:) is an illegal character in Windows, changed filenames so I can clone the repo.