alamid-schema should copy the definition before modifying it

[sbat]

It seems like mongoose cannot handle the normalized schema definition (for example type: "Array" will produce an error like "string is not a function"). Currently the schema definition needs to be copied on the application's side before passing it to alamid-schema.

[flootr]

Does 539fccb solve the problem?

[flootr]

@sbat or @meaku ?

[meaku]

Jup.

[jhnns]

I'm still not happy with cloning the definition inside alamid-schema. Imho a developer must always expect an object to be modified if it is passed to another function. This could be noted in the README, if the schema is intended to be shared with Mongoose.

[jhnns]

It's clearly the application's decision to share the definition, so it's the application's responsibility to copy it. That's like the convention in C that memory is always freed by the function/module/class who allocated it.