Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country names of search conditions not in alphabetical order (when locale = Japanese) #575

Closed
funkestefan opened this issue Sep 20, 2019 · 4 comments

Comments

@funkestefan
Copy link
Contributor

From a user:

I am using the system in Japanese, and the country names in the search conditions are in Japanese, but they are not in alphabetic order, either English alphabetic order or Japanese alphabetic order.

@ynbrthr
Copy link

ynbrthr commented Jun 3, 2020

It may be the case that it's true for other non-latin charsets as well. E.g. for Russian:
image
Notice the 'X' in the middle of the 'K's. Do we have folks from @peeringdb/pc with some familiarity with non-latin alphabets to check that? How does our sorting function deal with those?

Aside, it'd probably be a good idea to have a type-ahead field for searching cities, countries, rather than a drop-down

@arnoldnipper
Copy link
Contributor

Didn't we have a similar issue? I.e. sorting by locale? Right, it was #356

@ynbrthr
Copy link

ynbrthr commented Jun 3, 2020

Right, missed that. @funkestefan are you ok to close that, it should be taken care of by #356

@funkestefan
Copy link
Contributor Author

#356 should take care of that (sorting in browser with localecompare)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants