Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid URL can be set in website fields #583

Closed
ccaputo opened this issue Oct 4, 2019 · 3 comments
Closed

invalid URL can be set in website fields #583

ccaputo opened this issue Oct 4, 2019 · 3 comments
Assignees
Milestone

Comments

@ccaputo
Copy link
Contributor

ccaputo commented Oct 4, 2019

Both net and org pages allow an invalid URL to be set as a website address. For example, this can be configured: "http://https://TEST@www.example.xyz/"

Then when "peeringdb sync" is run on a client running django >=2.2.2, this will happen:

django.core.exceptions.ValidationError: {'website': ['Enter a valid URL.']}

This will be potentially fixed when #492 is completed, but a separate issue to check for or potentially handle separately.

@arnoldnipper arnoldnipper added this to the Decide milestone Nov 24, 2019
@grizz grizz self-assigned this Feb 8, 2020
@grizz
Copy link
Member

grizz commented Feb 8, 2020

@ccaputo Maybe we should check for reachability? Do you have a better idea?

@ccaputo
Copy link
Contributor Author

ccaputo commented Feb 8, 2020

@ccaputo Maybe we should check for reachability? Do you have a better idea?

I just checked with the current production site and "http://https://TEST@www.example.xyz/" can no longer be set, so I think this issue could be closed.

As for testing for reachability, I don't know. That's really a different issue and may not be a good idea since someone may want to configure a URL in advance of it existing, or the resource may be down at the moment of configuration.

@grizz
Copy link
Member

grizz commented Feb 9, 2020

Nice, fully agree and I'm not sure it would be a priority now. Thanks!

@grizz grizz closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants