Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KML Placemark/Point Meta Data Not Displaying Correctly #1475

Closed
martinhannigan opened this issue Nov 28, 2023 · 7 comments · Fixed by #1594
Closed

KML Placemark/Point Meta Data Not Displaying Correctly #1475

martinhannigan opened this issue Nov 28, 2023 · 7 comments · Fixed by #1594
Assignees
Labels
bug Time:Minor Up to 4 hours

Comments

@martinhannigan
Copy link

martinhannigan commented Nov 28, 2023

Describe the bug
When clicking on pin for KML meta data? Some display, and some have truncated data.

To Reproduce

  1. Go to KML data which reflects https://www.peeringdb.com/fac/3484 Crown Castle Boston
  2. Click the yellow pin for Crown Castle
  3. Metadata is truncated after Comment
  4. Click the pin for Databank which is next to it
  5. Meta data completes accurately

To easily fly to the bad pin, use the GE app to go to 1 Summer, Boston, MA

This is happening to more than a few placemarks. Or points. I thought I saw some inconsistency in the KML but the file was too big to easily diff the bad vs. good. HTH.

Expected behavior

Meta data display entirely when requested

Who is affected by the problem?

Users of the KMZ file

What is the impact?

Incomplete data

Are there security concerns?

No.

Are there privacy concerns?

No.

What are the proposed actions?

Evaluate, repair.

What is the proposed priority?

Not urgent

Provide a rationale for any/all of the above

Accuracy, consistency.

Additional context

Considered adding to enhancements list, but this bug has a different class so I didn't.

@martinhannigan
Copy link
Author

martinhannigan commented Nov 28, 2023

Additional debugging.

After more probing it appears conclusive that something is breaking in the markup related to comment.

Crown marked "all" their records with the comment "Previously Lightower" and none work

NTT FRA 2 has comments, truncated meta data
Digital Realty CHI (2299 Busse Road) has comments, truncated meta data
Databank facilities have no comments, all show meta data correctly
Equinix has commented records, they truncate after comments.

Seems like a pattern.

@leovegoda leovegoda self-assigned this Dec 4, 2023
@leovegoda leovegoda added this to the 1 Decide milestone Dec 4, 2023
@leovegoda
Copy link
Contributor

I see this. Also, when I look at https://www.peeringdb.com/fac/3152 I just see the comment but not the rest of the entry.
Screenshot 2023-12-04 at 07 50 37

@grizz
Copy link
Member

grizz commented Dec 12, 2023

+1 this should be checked out.

@grizz grizz added the Time:Minor Up to 4 hours label Dec 12, 2023
@mcmanuss8
Copy link
Contributor

+1 we should fix this

@AjSteller
Copy link

Thanks Martin for linking, I had missed this one when checking issues for duplicate before submitting, my apologies.

As noted in #1501, I was able to confirm that the notes being added as the "Description" are hiding the rest of the meta data. Verified this by manually deleting the notes text from the Description in Google Earth and the meta data shows up properly. Can do the same in reverse and go to properties of a placemark and add any text in the Description, once you do that you can't see any of the other meta data, only the text in the description.

Seems that the solution is likely to just not export the Notes field in to the Description since the Notes are also in the regular meta data table and shows up there.

Thanks all!

@martinhannigan
Copy link
Author

martinhannigan commented Jan 8, 2024 via email

@grizz
Copy link
Member

grizz commented Jan 13, 2024

Will be fixed with #1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Time:Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants