Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for md5 #2

Open
pajooh opened this issue Aug 25, 2014 · 5 comments
Open

support for md5 #2

pajooh opened this issue Aug 25, 2014 · 5 comments

Comments

@pajooh
Copy link

pajooh commented Aug 25, 2014

is it planned?

@mitar
Copy link
Member

mitar commented Aug 25, 2014

MD5 is insecure.

But pull requests are welcome.

@nschloe
Copy link

nschloe commented Aug 25, 2014

MD5 is insecure.

Indeed. There's a known and used collision attack for MD5.
However, there is no known preimage attack for MD5 which is why it is still very much in use for download verification and the like. Maybe it has it's place in meteor-crypto, too.

@mitar
Copy link
Member

mitar commented Aug 25, 2014

So the digest.js library we are using has support for it already. Also node.js crypto module has support for it. So adding MD5 and SHA1 this to this package would be quite straightforward. You can make a pull request with tests and documentation.

@pajooh
Copy link
Author

pajooh commented Aug 25, 2014

sometimes, just a hash function is needed, and it's security is not in concern.
like creating unique file name based on the hash of file content

@mitar
Copy link
Member

mitar commented Aug 25, 2014

You can still do SHA256 and just take the first N characters. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants