Fix for nvarchar(max) columns on sql 2005

[cloudkite]

When reading nvarchar max, ensure data is not falsey fixes nvarchar(max) columns on sql 2005

see #327

not sure why this doesn't fail on sql 2008+? Somehow data is never null even if db value is null?

[cloudkite]

ping @arthurschreiber sorry ;)

[arthurschreiber]

Hey there! I'm currently on vacation, please excuse this being left aside for this long. I've taken a quick look and the patch makes sense, but I'd like to take a deeper look. I promise I'll look into this as soon as I get back home, which will be in two weeks time. Thanks for the patch and your patience!

[cloudkite]

@arthurschreiber no problem, hope you have a great holiday.

If theres anything you need to help resolve or diagnose this let me know. Also just realised I forgot to attach the stacktrace

TypeError: Cannot read property 'toString' of null
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:399:18
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:406:14
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/token/stream-parser.js:405:9
    at Parser.awaitData (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/token/stream-parser.js:116:9)
    at Parser.readBuffer (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/token/stream-parser.js:402:12)
    at readMax (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:404:10)
    at readMaxNChars (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:398:3)
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:199:20
    at readDataLength (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:82:16)
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:94:5
    at readTextPointerNull (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:46:5)
    at exports.default (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:93:3)
    at next (/Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/token/row-token-parser.js:27:34)
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/token/row-token-parser.js:43:7
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:399:5
    at /Users/jonas/Projects/insight/node_modules/tedious-connection-pool/node_modules/tedious/lib/value-parser.js:448:5

[tswaters]

+1 we're getting this as well. In our case, it's xml columns that appear to be returning null.

TypeError: Cannot read property 'toString' of null,
    at /snip/tedious/lib/value-parser.js:399:18,
    at /snip/tedious/lib/value-parser.js:406:14,
    at /snip/tedious/lib/token/stream-parser.js:405:9,
    at Parser.awaitData (/snip/tedious/lib/token/stream-parser.js:116:9),
    at Parser.readBuffer (/snip/tedious/lib/token/stream-parser.js:402:12),
    at readMax (/snip/tedious/lib/value-parser.js:404:10),
    at readMaxNChars (/snip/tedious/lib/value-parser.js:398:3),
    at /snip/tedious/lib/value-parser.js:237:18,
    at readDataLength (/snip/tedious/lib/value-parser.js:86:14),
    at /snip/tedious/lib/value-parser.js:94:5,
    at readTextPointerNull (/snip/tedious/lib/value-parser.js:46:5),
    at exports.default (/snip/tedious/lib/value-parser.js:93:3),
    at next (/snip/tedious/lib/token/row-token-parser.js:27:34),
    at /snip/tedious/lib/token/row-token-parser.js:43:7,
    at /snip/tedious/lib/value-parser.js:399:5,
    at /snip/tedious/lib/value-parser.js:472:5

[dgasson]

+1, please! Same kind of problem. The suggested patch fixes the problem.

[arthurschreiber]

Hey all,

Thanks for all your input. I currently don't have access to my development machine, but I'll try to get this merged and push a new release before the end of the year.

Sorry for the delay and thanks for your patience!

[arthurschreiber]

Thank you! ❤️

[dgasson]

Excellent! Thank you muchly!

[cloudkite]

Thanks!! :)