Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIIF filename: incomplete urlencoding #690

Closed
docuracy opened this issue Mar 29, 2021 · 2 comments
Closed

IIIF filename: incomplete urlencoding #690

docuracy opened this issue Mar 29, 2021 · 2 comments

Comments

@docuracy
Copy link

We hit a snag due to the incomplete urlencoding of filenames in the document_filepart table. Colons are encoded as %2F but spaces remain unencoded. In our use case this caused a problem with a PHP file_get_contents call.

image

@rsimon
Copy link
Member

rsimon commented Mar 29, 2021

I don't think that's something that Recogito even touches. The filenames are inserted as-is, i.e. this should be the URL you originally imported to Recogito. (And how it was included in the manifest.)

@docuracy
Copy link
Author

Oops. Thanks, that would explain it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants