Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dedupe): consider category in deduplication #1462

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bboure
Copy link
Member

@bboure bboure commented Jul 8, 2020

Fixes #1460

Open for discussion:
Based on the other comparison methods, I considered records are the same if:

  • one of them is missing the category fields, or it is empty
  • at least one category match in both records

@missinglink
Copy link
Member

Looks good to me 👍

Did you get a chance to test it out?
Did it fix your transit stop issue?

@bboure
Copy link
Member Author

bboure commented Jul 8, 2020

Did you get a chance to test it out?
Did it fix your transit stop issue?

Yes, that solved my issue.
Thanks.

@orangejulius
Copy link
Member

Hey @bboure,
Thanks for the next day code delivery, very speedy :)

I think we will have to consider a record with no categories different from one with categories. For example, your example query for Manneken pis shows the same results with your changes (which I've put on the Geocode Earth dev server) because the statue record does not have any categories.

I believe lots of OSM records do not have categories, so there would be a lot of cases where this PR would not change much.

If you get a chance to try out that change, feel free to add it to your PR. Otherwise we may try it out as well.

@bboure
Copy link
Member Author

bboure commented Jul 8, 2020

@orangejulius Sorry, I did not notice that. In my case I do have a category because I am using a custom category mapper.

I will add that change to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplication issue with transit stops
3 participants