fix incorrect matching of Thai characters in FTS5 #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a bug in the FTS5 analysis module regarding Thai characters.
It should be that the
tokens.token
column and thefulltext.fulltext
column contain the same token and therefore have the same matching functionality, the FTS5 table is significantly faster (even when including theJOIN
) so we generally use that instead of the index ontokens
.However it turns out, for Thai at least, that this isn't true:
It seems that the
FTS5
module erroneously performs prefix matching of this character despite the query not containing a star and therefore not requesting a prefix search.This PR is a simple workaround for this, and any other cases where the two columns don't match, we simple check both.