Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success check in M2MNsdlInterface::create_nsdl_list_structure() checks only success of last call to create_nsdl_structure() #14

Closed
markus-becker-tridonic-com opened this issue Aug 13, 2018 · 3 comments

Comments

@markus-becker-tridonic-com

success is assigned multiple times at
https://github.com/ARMmbed/mbed-cloud-client/blob/9b0bc6a2f3f1f5dbb5be1827db83004d531b99c9/mbed-client/source/m2mnsdlinterface.cpp#L375

There is no early return on fail. Thus only the last assignment will be returned. This assumes that all following calls after an initial fail will always fail. Was not the case in our codebase.

@markus-becker-tridonic-com
Copy link
Author

FYI: @MarceloSalazar @karsev

@ciarmcom
Copy link

ARM Internal Ref: IOTCLT-2906

@anttiylitokola
Copy link

Thanks for your report. This has now been fixed and the change will be available in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants