Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy timezones should be mapped to current valid list #12

Open
JordanMagnuson opened this issue Mar 18, 2021 · 2 comments
Open

Legacy timezones should be mapped to current valid list #12

JordanMagnuson opened this issue Mar 18, 2021 · 2 comments

Comments

@JordanMagnuson
Copy link

JordanMagnuson commented Mar 18, 2021

This library currently returns a number of timezones that have been deprecated by the tz database (and consequently current versions of programming languages like PHP).

A few legacy timezones that I have noticed being returned recently include:

  • America/Buenos_Aires => Should be America/Argentina/Buenos_Aires
  • America/Indianapolis => Should be America/Indiana/Indianapolis
  • Asia/Calcutta => Should be Asia/Kolkata
  • America/Montreal => Doesn't exist in PHP's current list. Should be America/Toronto I believe.
  • Etc/GMT-8 => Should be mapped to Asia/Hong_Kong or similar.
  • Etc/GMT-2 => Should be mapped to Europe/Amsterdam or similar.

See PHP's deprecated timezone list here: https://www.php.net/manual/en/timezones.others.php
(Which matches up with the tz database. see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones)

Ideally all of these legacy timezones should be mapped to currently supported values as listed at e.g. https://www.php.net/manual/en/timezones

@JordanMagnuson JordanMagnuson changed the title America/Montreal not a valid PHP timezone Various invalid timezones in PHP Mar 18, 2021
@ankit-gaur
Copy link

Asia/Calcutta => Should be Asia/Kolkata --> Asia/Calcutta is correct as Asia/Kolkata is deprecated timezone

@JordanMagnuson
Copy link
Author

JordanMagnuson commented May 18, 2022

@ankit-gaur actually, it's the opposite. Asia/Calcutta was changed to Asia/Kolkata. Asia/Calcutta is deprecated. See deprecated list at https://www.php.net/manual/en/timezones.others.php or https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

@JordanMagnuson JordanMagnuson changed the title Various invalid timezones in PHP Legacy timezones should be mapped to current valid list May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants