Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow custom struct unmarshal with UnmarshalText #329

Closed
billryan opened this issue Feb 1, 2020 · 1 comment · Fixed by #375
Closed

allow custom struct unmarshal with UnmarshalText #329

billryan opened this issue Feb 1, 2020 · 1 comment · Fixed by #375
Labels
feature Issue asking for a new feature in go-toml.

Comments

@billryan
Copy link

billryan commented Feb 1, 2020

Is your feature request related to a problem? Please describe.
I'm always frustrated when I want to support my struct, e.g. custom struct.

Describe the solution you'd like
Use encoding.TextUnmarshaler, we can implement UnmarshalText.

Describe alternatives you've considered
Universal unmarshal solutions.

Additional context
BurntSushi/toml
@billryan billryan mentioned this issue Feb 2, 2020
Closed
@pelletier pelletier added the feature Issue asking for a new feature in go-toml. label Feb 3, 2020
@pelletier
Copy link
Owner

Thanks! Being more in-line with existing patterns would be a good thing.

@oncilla oncilla mentioned this issue Apr 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Issue asking for a new feature in go-toml.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unmarshal: support encoding.TextUnmarshaler oncilla/go-toml
2 participants
@pelletier @billryan