Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ellipse #29

Closed
GMartigny opened this issue Jul 25, 2018 · 1 comment
Closed

Add ellipse #29

GMartigny opened this issue Jul 25, 2018 · 1 comment
Assignees
Labels
✨ enhancement New feature or request

Comments

@GMartigny
Copy link
Member

Ellipses are one of the most common shape and it's easy to draw in canvas.

However, I don't know how it should integrate in the current dependency tree.

Current tree:

  • Component
    • Arc
      • Circle

Possible solutions:

  1. Split arcs and full ellipses
  • Component
    • EllipseArc
      • CircleArc
    • Ellipse
      • Circle
  1. Add another branch
  • Component
    • EllipseArc
      • Ellipse
    • Arc
      • Circle

(1) IMO, arcs (ellipse or circle) should be treated by default as stroke (like lines and paths). Which mean that they could even inherit from Line.

(2) In the other hand, circle is just a specific arc (just as square is a specific rectangle) as much as a specific ellipse. Since double inheritance is impossible in JS, it's not an option.

@GMartigny GMartigny added the ✨ enhancement New feature or request label Jul 25, 2018
@GMartigny GMartigny added this to the v2 milestone Jul 25, 2018
@GMartigny GMartigny self-assigned this Aug 2, 2018
@GMartigny
Copy link
Member Author

Fixed by 57c6b47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant