Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide typescript types #88

Closed
ecstrema opened this issue Feb 8, 2021 · 3 comments
Closed

Provide typescript types #88

ecstrema opened this issue Feb 8, 2021 · 3 comments
Labels
🙏 help wanted Extra attention is needed 🔧 technical Change on technical aspect of the project

Comments

@ecstrema
Copy link
Contributor

ecstrema commented Feb 8, 2021 •
edited

This library does not provide typescript declaration files. Is there any chance it ever will?

It should be as simple as installing the typescript compiler (tsc) and running tsc src/**/*.js --declaration --allowJs --emitDeclarationOnly --outDir types and adding a reference to the types in package.json.
@GMartigny
Copy link
Member

This is a good idea.

Can tsc infer types definition from pure Javascript ?

@GMartigny GMartigny added 🙏 help wanted Extra attention is needed 🔧 technical Change on technical aspect of the project labels Feb 8, 2021
@ecstrema
Copy link
Contributor Author

ecstrema commented Feb 8, 2021

Yes it can, see https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html

@ecstrema ecstrema mentioned this issue Feb 9, 2021
Merged
@GMartigny
Copy link
Member

Fixed by #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙏 help wanted Extra attention is needed 🔧 technical Change on technical aspect of the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GMartigny @ecstrema