Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust format checker to CI #477

Open
TorstenStueber opened this issue May 20, 2024 · 2 comments
Open

Add Rust format checker to CI #477

TorstenStueber opened this issue May 20, 2024 · 2 comments

Comments

@TorstenStueber
Copy link
Member

Currently the formatting of code in PRs is not checked and therefore we have a lot of improperly formatted code on main (e.g., the spacing around the / operator is missing here).

This leads to a situation where some PRs happen to be overly bloated as they happen to correct the formatting of some code files that might not even be related to the PR.

TODO

  • add cargo fmt --check as a step to CI and let the action fail if it exits with non-0
  • apply proper formatting to the complete repository
@TorstenStueber
Copy link
Member Author

@pendulum-chain/product this is to keep the code base healthy and to make code reviews more straight forward.

@TorstenStueber
Copy link
Member Author

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant