Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking x.com blocks nginx.com #65

Closed
olfek opened this issue Aug 24, 2023 · 5 comments · Fixed by #66
Closed

Blocking x.com blocks nginx.com #65

olfek opened this issue Aug 24, 2023 · 5 comments · Fixed by #66
Milestone

Comments

@olfek
Copy link
Contributor

olfek commented Aug 24, 2023

No description provided.

@olfek olfek changed the title Blocking x.com blocks nginx.com Blocking x.com blocks nginx.com Aug 24, 2023
@penge
Copy link
Owner

penge commented Aug 24, 2023

That's quite ironic. So that's why Twitter got renamed! (cannot be blocked!) 🤣

@penge
Copy link
Owner

penge commented Aug 24, 2023

The problem is right here:

const foundRule = rules.find((rule) => normalizedUrl.startsWith(rule.path) || normalizedUrl.endsWith(rule.path));

I'll fix it in the morning.

@penge penge added this to the 7.0.2 milestone Aug 25, 2023
@penge penge closed this as completed in #66 Aug 27, 2023
@olfek
Copy link
Contributor Author

olfek commented Aug 27, 2023

Any chance you could upload the signed packages to the GitHub release so we can install the updates sooner and not have to wait for the extension store extensions update cadence?

@penge
Copy link
Owner

penge commented Aug 27, 2023

It's 2 hours on Firefox already. This time it went quickly. I guess only first-ever release was slow.

https://addons.mozilla.org/en-US/android/addon/penge-block-site/

@penge
Copy link
Owner

penge commented Aug 27, 2023

20230827_183758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants